Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D66B1066D for ; Sat, 21 Sep 2013 11:31:03 +0000 (UTC) Received: (qmail 82557 invoked by uid 500); 21 Sep 2013 11:31:02 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 82507 invoked by uid 500); 21 Sep 2013 11:30:56 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 82499 invoked by uid 99); 21 Sep 2013 11:30:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Sep 2013 11:30:52 +0000 Date: Sat, 21 Sep 2013 11:30:52 +0000 (UTC) From: "Oleg Kalnichevski (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1401) Add Javadoc or docs link to RequestConfig.Builder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773794#comment-13773794 ] Oleg Kalnichevski commented on HTTPCLIENT-1401: ----------------------------------------------- Unless I am missing something all request config parameters are documented in RequestConfig. http://hc.apache.org/httpcomponents-client-4.3.x/httpclient/apidocs/org/apache/http/client/config/RequestConfig.html By the way, Java Sockets use 'int' to represent both socket (read) and connect timeouts. Oleg > Add Javadoc or docs link to RequestConfig.Builder > ------------------------------------------------- > > Key: HTTPCLIENT-1401 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1401 > Project: HttpComponents HttpClient > Issue Type: New Feature > Components: Documentation > Affects Versions: 4.3 Beta2 > Reporter: Andrew Bissell > > The RequestConfig.Builder provides no hints as to whether, for example, setConnectionRequestTimeout(int) is expecting seconds or milliseconds (and confusion seems likely given that milliseconds are usually stored in a long variable). Other methods on the config builders seem similarly ambiguous. A simple Javadoc comment -- or at least a link to documentation/tutorial pages explaining use of the Builder -- would be helpful to avoid having to either Google for the answer or set up time-consuming experiments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org