Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D86810ECF for ; Mon, 16 Sep 2013 14:28:58 +0000 (UTC) Received: (qmail 89972 invoked by uid 500); 16 Sep 2013 14:28:57 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 89755 invoked by uid 500); 16 Sep 2013 14:28:56 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 89503 invoked by uid 99); 16 Sep 2013 14:28:54 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2013 14:28:54 +0000 Date: Mon, 16 Sep 2013 14:28:54 +0000 (UTC) From: "Oleg Kalnichevski (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1399) NPE in org.apache.http.client.methods.RequestBuilder line 237 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768355#comment-13768355 ] Oleg Kalnichevski commented on HTTPCLIENT-1399: ----------------------------------------------- Fixed as well. Oleg > NPE in org.apache.http.client.methods.RequestBuilder line 237 > ------------------------------------------------------------- > > Key: HTTPCLIENT-1399 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1399 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient > Affects Versions: 4.3 Final > Reporter: wangzhenghang > Fix For: 4.3.1 > > > public RequestBuilder setHeader(final String name, final String value) { > if (headergroup != null) { > headergroup = new HeaderGroup(); > } > this.headergroup.updateHeader(new BasicHeader(name, value)); > return this; > } > Obviously it was a copy-paste error. "headergroup != null" should be "headergroup == null" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org