hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1401) Add Javadoc or docs link to RequestConfig.Builder
Date Sat, 21 Sep 2013 11:30:52 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773794#comment-13773794
] 

Oleg Kalnichevski commented on HTTPCLIENT-1401:
-----------------------------------------------

Unless I am missing something all request config parameters are documented in RequestConfig.

http://hc.apache.org/httpcomponents-client-4.3.x/httpclient/apidocs/org/apache/http/client/config/RequestConfig.html

By the way, Java Sockets use 'int' to represent both socket (read) and connect timeouts.

Oleg
                
> Add Javadoc or docs link to RequestConfig.Builder
> -------------------------------------------------
>
>                 Key: HTTPCLIENT-1401
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1401
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: Documentation
>    Affects Versions: 4.3 Beta2
>            Reporter: Andrew Bissell
>
> The RequestConfig.Builder provides no hints as to whether, for example, setConnectionRequestTimeout(int)
is expecting seconds or milliseconds (and confusion seems likely given that milliseconds are
usually stored in a long variable). Other methods on the config builders seem similarly ambiguous.
A simple Javadoc comment -- or at least a link to documentation/tutorial pages explaining
use of the Builder -- would be helpful to avoid having to either Google for the answer or
set up time-consuming experiments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message