Return-Path: 
 <dev-return-28617-apmail-hc-dev-archive=hc.apache.org@hc.apache.org>
X-Original-To: apmail-hc-dev-archive@www.apache.org
Delivered-To: apmail-hc-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E4B27102A7
	for <apmail-hc-dev-archive@www.apache.org>;
 Thu, 15 Aug 2013 22:58:30 +0000 (UTC)
Received: (qmail 77683 invoked by uid 500); 15 Aug 2013 22:58:16 -0000
Delivered-To: apmail-hc-dev-archive@hc.apache.org
Received: (qmail 77635 invoked by uid 500); 15 Aug 2013 22:58:05 -0000
Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hc.apache.org>
List-Post: <mailto:dev@hc.apache.org>
List-Id: <dev.hc.apache.org>
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Delivered-To: mailing list dev@hc.apache.org
Received: (qmail 77595 invoked by uid 99); 15 Aug 2013 22:58:02 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Aug 2013 22:58:02 +0000
Date: Thu, 15 Aug 2013 22:58:02 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.12663850.1376573999277.76643.1376607482621@arcas>
In-Reply-To: <JIRA.12663850.1376573999277@arcas>
References: <JIRA.12663850.1376573999277@arcas>
Subject: [jira] [Commented] (HTTPCLIENT-1387) Replace URICollection with
 List<URI>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741620#comment-13741620 ] 

Sebb commented on HTTPCLIENT-1387:
----------------------------------

I realise that there is no runtime guarantee. Generics warnings are compile-time only. 
However we should strive for code that does not fail with CCEs provided that there are no compile-time warnings.

If we are sure that the REDIRECT_LOCATIONS attribute can only contain URIs, then the @SuppressWarnings is OK, and we should document that. However if REDIRECT_LOCATIONS is not compile-time safe, then we should note that.

The generics warnings are not perfect, but they can catch coding errors.

The point of commenting the suppression is to show that the issue has been considered, not just ignored, so that only unavoidable warnings are suppressed.
                
> Replace URICollection with List<URI>
> ------------------------------------
>
>                 Key: HTTPCLIENT-1387
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1387
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.3 Beta2
>            Reporter: James Leigh
>              Labels: patch
>             Fix For: 4.3 Final
>
>         Attachments: HTTPCLIENT-1387.patch
>
>
> The 4.3 API should use List<URI> interface (as opposed to URICollection) for redirect locations, while also providing 4.2 RedirectLocations binary compatibility.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org