hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Leigh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1387) Replace URICollection with List<URI>
Date Thu, 15 Aug 2013 20:18:57 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741437#comment-13741437
] 

James Leigh commented on HTTPCLIENT-1387:
-----------------------------------------

Hi Sebb,

I am not sure what you are looking for in this comment. There are no additional risks with
this getter method than any of the other getter methods in HttpClientContext.

The @SuppressWarnings("unchecked") is needed because Java does not provide a way to safely
cast a type parameter and for good reason. Due to type-erasure, there is no way for this method
to ensure that the attribute value object actually has a URI parameter type. Like with any
parameter typed collection, there is a risk that the elements of the collection are not actually
of the same type.

James
                
> Replace URICollection with List<URI>
> ------------------------------------
>
>                 Key: HTTPCLIENT-1387
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1387
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.3 Beta2
>            Reporter: James Leigh
>              Labels: patch
>             Fix For: 4.3 Final
>
>         Attachments: HTTPCLIENT-1387.patch
>
>
> The 4.3 API should use List<URI> interface (as opposed to URICollection) for redirect
locations, while also providing 4.2 RedirectLocations binary compatibility.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message