Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BDCB10CBB for ; Thu, 11 Jul 2013 19:21:48 +0000 (UTC) Received: (qmail 97629 invoked by uid 500); 11 Jul 2013 19:21:48 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 97587 invoked by uid 500); 11 Jul 2013 19:21:48 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 97578 invoked by uid 99); 11 Jul 2013 19:21:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jul 2013 19:21:48 +0000 Date: Thu, 11 Jul 2013 19:21:48 +0000 (UTC) From: "Dmitry Potapov (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HTTPASYNC-48) InternalHttpAsyncClientThread.reactorThread should be created via ThreadFactory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPASYNC-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Potapov updated HTTPASYNC-48: ------------------------------------ Attachment: httpasyncclient.patch Here the patch, which allows ThreadFactory configuration in HttpAsyncClientBuilder. I've write it on top of trunk and "mvn install" detected no issues. This patch can be also applied to source of 4.0-beta4 without any problems. > InternalHttpAsyncClientThread.reactorThread should be created via ThreadFactory > ------------------------------------------------------------------------------- > > Key: HTTPASYNC-48 > URL: https://issues.apache.org/jira/browse/HTTPASYNC-48 > Project: HttpComponents HttpAsyncClient > Issue Type: Improvement > Affects Versions: 4.0-beta4, Future > Reporter: Dmitry Potapov > Priority: Trivial > Attachments: httpasyncclient.patch > > > InternalHttpAsyncClientThread.reactorThread is created via implicit call to "new Thread()" which doesn't allow to configure reactor thread priority and name, which may lead to some inconvenience during debug or performance profiling. > My proposal is to pass java.util.concurrent.ThreadFactory to InternalHttpAsyncClientThread. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org