hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Checkstyle: NewlineAtEndOfFile should be enabled
Date Thu, 25 Jul 2013 20:08:25 GMT
There are several java files in the 4.2.5 tag that don't have an EOL
on the last line.

This causes problems when comparing the source archive with the tag,
as the EOL conversion filter seems to add the final EOL.

It could be argued that the filter should not add the EOL, but given
that some SCMs (including SVN) complain about missing EOL at EOF, it
seems to me it would be better to ensure that the EOL is present.

Unfortunately the check does not take the setting from the rest of the
file (it would be better if the check ensured that all the lines had
consistent EOLs), so it's going to be necessary to only apply the
check to files which have svn:eol-style=native

For example:

<module name="NewlineAtEndOfFile">
    <property name="fileExtensions" value="java, xml, ..."/>

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message