hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: UnicodeLittleUnmarked or UTF-16LE in NTLM code?
Date Mon, 08 Jul 2013 12:49:35 GMT
On Jul 8, 2013, at 6:30, Oleg Kalnichevski <olegk@apache.org> wrote:

> On Mon, 2013-07-08 at 11:10 +0100, sebb wrote:
>> The NTLM code uses the charset UnicodeLittleUnmarked a lot.
>>
>> The official page:
>>
>> http://docs.oracle.com/javase/1.5.0/docs/guide/intl/encoding.doc.html
>>
>> says they are the same, but different APIs use a different canonical name.
>>
>> I assume the methods will therefore take either.
>>
>> Might be worth changing to the slightly shorter - but more obviously
>> 16 bit - name?
>>
>> In any case, extracting as a constant and documenting the choice would
>> be a good idea.
>> Especially since the code also uses US-ASCII or ASCII sometimes (why?)
>
> Sebastian,
>
> I would like to propose to move to Java 1.6 at some point (rather sooner
> than later). One of the reasons to make this move is to be able to use
> Charset variant of String#getBytes() method and to clean up the use of
> various charsets throughout the code base, not just NTLM code.
>
> Maintaining Java 1.5 compatibility has been getting increasingly
> difficult and increasingly pointless. The question is whether this is
> too later for 4.3 or not.

I would move to Java 6 now, a major release is as good a time as any
and gives us the opportunity for changes that are easier to make than
in a minor release. I would not want to be stuck with supporting Java
5 until the next major release.

Gary

>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message