hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: EOL not being fixed in some resources; should not fix EOL at EOF
Date Fri, 26 Jul 2013 11:46:29 GMT
On Fri, 2013-07-26 at 11:52 +0100, sebb wrote:
> The EOL is not being correctly converted for the following files:
> 
> resources/css/*.css
> resources/xsl/*.xsl
> META-INF/NOTICE
> META-INF/LICENSE
> version.properties
> 

These are resources and I personally think they should not be meddled
with.

> I think that is handled in rc.gradle:CopySpec sources()
> It looks like it should be sufficient to just add some extra includes
> to the first section.
> 
> I also now think the filter should not attempt to fix EOL at EOF, i.e.
> the filter should have setFixLast(false);
> If the final EOL is missing in SVN, it should remain so in the archive.
> I assume this would have to go into Line.groovy, but I've no idea how
> to do that.
> 

I adjusted the parameter map passed to the filter. Last line fix is now
set to false.

Oleg 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message