hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Checkstyle: NewlineAtEndOfFile should be enabled
Date Fri, 26 Jul 2013 07:23:02 GMT
On Thu, 2013-07-25 at 21:08 +0100, sebb wrote:
> There are several java files in the 4.2.5 tag that don't have an EOL
> on the last line.
> 
> This causes problems when comparing the source archive with the tag,
> as the EOL conversion filter seems to add the final EOL.
> 
> It could be argued that the filter should not add the EOL, but given
> that some SCMs (including SVN) complain about missing EOL at EOF, it
> seems to me it would be better to ensure that the EOL is present.
> 
> Unfortunately the check does not take the setting from the rest of the
> file (it would be better if the check ensured that all the lines had
> consistent EOLs), so it's going to be necessary to only apply the
> check to files which have svn:eol-style=native
> 
> For example:
> 
> <module name="NewlineAtEndOfFile">
>     <property name="fileExtensions" value="java, xml, ..."/>
> </module>
> 

The 4.2.x branch is about to become inactive. I think we should
concentrate on 4.3 as of now. By all of means feel free to add the check
to the trunk.

Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message