Return-Path: 
 <dev-return-28084-apmail-hc-dev-archive=hc.apache.org@hc.apache.org>
X-Original-To: apmail-hc-dev-archive@www.apache.org
Delivered-To: apmail-hc-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A777610B63
	for <apmail-hc-dev-archive@www.apache.org>;
 Wed,  5 Jun 2013 16:49:27 +0000 (UTC)
Received: (qmail 58653 invoked by uid 500); 5 Jun 2013 16:49:27 -0000
Delivered-To: apmail-hc-dev-archive@hc.apache.org
Received: (qmail 58545 invoked by uid 500); 5 Jun 2013 16:49:24 -0000
Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hc.apache.org>
List-Post: <mailto:dev@hc.apache.org>
List-Id: <dev.hc.apache.org>
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Delivered-To: mailing list dev@hc.apache.org
Received: (qmail 58537 invoked by uid 99); 5 Jun 2013 16:49:22 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2013 16:49:22 +0000
X-ASF-Spam-Status: No, hits=1.5 required=5.0
	tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com
 designates 209.85.214.53 as permitted sender)
Received: from [209.85.214.53] (HELO mail-bk0-f53.google.com) (209.85.214.53)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2013 16:49:17 +0000
Received: by mail-bk0-f53.google.com with SMTP id e11so461022bkh.26
        for <dev@hc.apache.org>; Wed, 05 Jun 2013 09:48:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=kPjZZZfgLyxHp7BJFLLiVJ3cTQgZ7LAtfr/WA1nKHAc=;
        b=TdfI5uzgUkulxa83PHj+fdgy5ZveD6afIBGY6CEQDVremDNea/YdEsOK/X08bThjdK
         fONwBp1fbkgJxEcahkUVU6OyGqoxw2uI/I86N5K44qBzuOxScatUnezu4oSv9Bd8mYUm
         w36yV+xN/TTKcM4MpaHKu+Iu6FowE5+6VQF1Pgo4XlLEc1s6wmjI6IdX5hFCcltVNKo0
         yMF+FHkvqZwHfewrSppXAkfltVoZf5g9nltyMKAmZrrY82gb7xEOFm+cqDhs+xncv7A/
         KcPxVJygswqnBvYlK5tmSKvssqzd/C3pQMNPYd3JJxZqs1Elf8vrFrpJiW/DNjJCVS6I
         vLdQ==
MIME-Version: 1.0
X-Received: by 10.204.239.131 with SMTP id kw3mr9738111bkb.156.1370450936808;
 Wed, 05 Jun 2013 09:48:56 -0700 (PDT)
Received: by 10.204.50.139 with HTTP; Wed, 5 Jun 2013 09:48:56 -0700 (PDT)
Date: Wed, 5 Jun 2013 12:48:56 -0400
Message-ID: 
 <CACZkXPwVvNznggaxNkB2UKAstF6j4Xbc6Mx2DsaGK4vBXryF9w@mail.gmail.com>
Subject: [httpclient] URLEncodedUtils parser delimiters
From: Gary Gregory <garydgregory@gmail.com>
To: HttpComponents Project <dev@hc.apache.org>
Content-Type: multipart/alternative; boundary=20cf3022385745888304de6af9e1
X-Virus-Checked: Checked by ClamAV on apache.org

--20cf3022385745888304de6af9e1
Content-Type: text/plain; charset=UTF-8

Hi All:

It seems to me that URLEncodedUtils.DELIM should be:

    new char[] { '&', ';' };

instead of:

    new char[] { '&' };

All the tests pass with this change. It just seems like an omission.

Also in
org.apache.http.client.utils.URLEncodedUtils.parse(List<NameValuePair>,
Scanner, String)

    scanner.useDelimiter(PARAMETER_SEPARATOR);

should be:

    scanner.useDelimiter("[&;]");

Am I missing something?

FWIW, I tested with this

    private static final char[] DELIM = new char[] { '&', ';' };
    private static final String DELIM_PATTERN = "[" + new String(DELIM) +
"]";

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--20cf3022385745888304de6af9e1--