hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Leigh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1370) Response to Non-GET Requests Should Never be Cached With the Default Response CachingPolicy
Date Thu, 13 Jun 2013 16:23:20 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682385#comment-13682385
] 

James Leigh commented on HTTPCLIENT-1370:
-----------------------------------------

Yes, however, there is non-compliant behaviour going on here. Because a response to an OPTIONS
request is put into the cache, it will later be served to clients (as cache hits) in response
to GET requests with the same URI (the cache does not distinguish between the request method).

Although, a simpler fix for this test could be applied elsewhere, the execution flow for this
shared/auth/public scenario would still divert and isResponseCacheable(String, HttpResponse)
would not be called in this scenario. I will write some more tests to demonstrate this.

James
                
> Response to Non-GET Requests Should Never be Cached With the Default Response CachingPolicy
> -------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1370
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1370
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: CacheHttpClient Caching components
>    Affects Versions: 4.3 Beta2
>            Reporter: James Leigh
>              Labels: patch
>             Fix For: 4.3 Beta3
>
>         Attachments: HTTPCLIENT-1370.patch
>
>
> HttpClient caches response to non-GET requests when a shared cache is used and an Authorization
header is present with Cache-Control: public.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message