hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPASYNC-44) CachingHttpAsyncClient Has Gotten Out Of Sync With CachingExec
Date Thu, 13 Jun 2013 07:48:20 GMT

     [ https://issues.apache.org/jira/browse/HTTPASYNC-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPASYNC-44.
----------------------------------------

    Resolution: Fixed

Hi James
The big problem with HTTP caching is that it has been effectively designed with blocking i/o
in mind. Being inherently blocking caching just does not work well in an asynchronous mode.
Presently caching in HttpAsyncClient is just one big horrid hack.

I committed your patch with some changes. 

(1) Content streaming in an async mode works completely differently than in a sync mode. 
CloseableHttpResponse is simply not applicable to CachingHttpAsyncClient as there are no resources
that need to be closed and deallocated. Response content is always buffered in memory.

(2) We do not use Trace priority anywhere else, so I felt for the sake of consistency we should
use Debug.

Many thanks for contributing this patch.

Oleg
                
> CachingHttpAsyncClient Has Gotten Out Of Sync With CachingExec
> --------------------------------------------------------------
>
>                 Key: HTTPASYNC-44
>                 URL: https://issues.apache.org/jira/browse/HTTPASYNC-44
>             Project: HttpComponents HttpAsyncClient
>          Issue Type: Bug
>    Affects Versions: 4.0-beta4
>            Reporter: James Leigh
>              Labels: patch
>             Fix For: 4.0-beta5
>
>         Attachments: HTTPASYNC-44.patch
>
>
> Many fixes for CachingExec have not bee applied to CachingHttpAsyncClient, which copied
much of it's code from CachingExec.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message