hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1493743
Date Mon, 17 Jun 2013 13:15:53 GMT
On Mon, Jun 17, 2013 at 9:03 AM, Oleg Kalnichevski <olegk@apache.org> wrote:

> On Mon, 2013-06-17 at 12:44 +0000, sebb@apache.org wrote:
> > Author: sebb
> > Date: Mon Jun 17 12:44:30 2013
> > New Revision: 1493743
> >
>
> ...
>
> > Modified:
> httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
> > URL:
> http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java?rev=1493743&r1=1493742&r2=1493743&view=diff
> >
> ==============================================================================
> > ---
> httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
> (original)
> > +++
> httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
> Mon Jun 17 12:44:30 2013
> > @@ -178,7 +178,7 @@ public class LengthDelimitedEncoder exte
> >          buffer.append("; pos: ");
> >          buffer.append(this.contentLength - this.remaining);
> >          buffer.append("; completed: ");
> > -        buffer.append(this.completed);
> > +        buffer.append(isCompleted());
> >          buffer.append("]");
> >          return buffer.toString();
> >      }
> >
> >
>
> What is the benefit of doing so? Now we have a bizarre situation when
> one instance variable is accessed via a getter and two are not.
>

Accessing an ivar breaks encapsulation, which means that a call site has
intimate knowledge of the internals of the object. What is worse, is that
if an object also has getters and setters, these methods may be doing
additional work. At work, all ivars are private unless there is a string
case for a subclass needing access.

Gary


>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message