hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: svn commit: r1493743
Date Mon, 17 Jun 2013 13:03:38 GMT
On Mon, 2013-06-17 at 12:44 +0000, sebb@apache.org wrote:
> Author: sebb
> Date: Mon Jun 17 12:44:30 2013
> New Revision: 1493743
> 

...

> Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java?rev=1493743&r1=1493742&r2=1493743&view=diff
> ==============================================================================
> --- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
(original)
> +++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
Mon Jun 17 12:44:30 2013
> @@ -178,7 +178,7 @@ public class LengthDelimitedEncoder exte
>          buffer.append("; pos: ");
>          buffer.append(this.contentLength - this.remaining);
>          buffer.append("; completed: ");
> -        buffer.append(this.completed);
> +        buffer.append(isCompleted());
>          buffer.append("]");
>          return buffer.toString();
>      }
> 
> 

What is the benefit of doing so? Now we have a bizarre situation when
one instance variable is accessed via a getter and two are not.

Oleg 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message