hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: [VOTE][LAZY] Release HC stylecheck 1 based on RC1
Date Wed, 12 Jun 2013 15:30:56 GMT
On Wed, 2013-06-12 at 11:21 -0400, Gary Gregory wrote:
> On Wed, Jun 12, 2013 at 11:15 AM, Oleg Kalnichevski <olegk@apache.org>wrote:
> 
> > On Wed, 2013-06-12 at 11:10 -0400, Gary Gregory wrote:
> > > Can I step back a second and ask why we are not sharing a checkstyle.xml
> > > file, for example, the way we do it in Log4j 2, which is also a
> > > multi-module project?
> > >
> > > Gary
> > >
> >
> > That is the whole point of publishing module: to make it re-usable as a
> > binary artifact by all HC projects.
> >
> 
> I understand the point of it, but it sure seems more complicated that just
> having a file sitting in the root directory.
> 

In the root directory of what exactly? We now have 4 (or maybe even
more) instances of hc-stylecheck.xml sitting around in various
directories.

Oleg
 

> Gary
> 
> 
> >
> > There are two checkstyle files though: default.xml and minimal.xml
> >
> > Oleg
> >
> > >
> > > On Wed, Jun 12, 2013 at 10:00 AM, Oleg Kalnichevski <olegk@apache.org
> > >wrote:
> > >
> > > > Please vote on releasing these packages as HttpComponents Style-check
> > 1.
> > > > The vote is open for for 72 hours and requires a lazy consensus to
> > pass.
> > > > The vote passes if there are no vetoes (binding -1 votes).
> > > >
> > > > Maven artefacts:
> > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachehttpcomponents-015/org/apache/httpcomponents/hc-stylecheck/
> > > >
> > > > SVN tag:
> > > >
> > https://svn.apache.org/repos/asf/httpcomponents/hc-stylecheck/tags/1-RC1/
> > > >
> > > > Change log:
> > > > -----------
> > > > There are two sets of style check rules currently provided this module:
> > > > default and minimal.
> > > >
> > > > Minimal rules are:
> > > > ------------------
> > > > * ASLv2 header check
> > > > * While space checks (no tabs, no trailing spaces)
> > > > * Imports checks (unused imports, star imports, duplicated imports)
> > > > * #equals has a matching #hashCode check
> > > >
> > > > Default rules are:
> > > > ------------------
> > > > * All minimal checks
> > > > * Local variable and parameter checks: all immutable local variables
> > > > method parameters must be marked 'final'
> > > >
> > > >
> > --------------------------------------------------------------------------
> > > >  Vote: HC style-check 1 release
> > > >  [ ] +1 Release the packages as HC style-check 1.
> > > >  [ ] -1 I am against releasing the packages (must include a reason).
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > > For additional commands, e-mail: dev-help@hc.apache.org
> > > >
> > > >
> > >
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
> 
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message