hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arūnas Bendoraitis (JIRA) <j...@apache.org>
Subject [jira] [Created] (HTTPCORE-339) org.apache.http.entity.ContentType contructor should check empty charsets.
Date Tue, 14 May 2013 17:45:17 GMT
Arūnas Bendoraitis created HTTPCORE-339:

             Summary: org.apache.http.entity.ContentType contructor should check empty charsets.
                 Key: HTTPCORE-339
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-339
             Project: HttpComponents HttpCore
          Issue Type: Bug
            Reporter: Arūnas Bendoraitis

            final String mimeType,
            final NameValuePair[] params) throws UnsupportedCharsetException {
        this.mimeType = mimeType;
        this.params = params;
        final String s = getParameter("charset");
        this.charset = s != null ? Charset.forName(s) : null;

It only checks for null, but should check for empty as well.

Last line should be replaced with:
 this.charset = !TextUtils.isBlank(charset) ? Charset.forName(s) : null;

In create method as far as I remember there was the same bug earlier, but now it's fixed and
is like this:

    public static ContentType create(
            final String mimeType, final String charset) throws UnsupportedCharsetException
        return create(mimeType, !TextUtils.isBlank(charset) ? Charset.forName(charset) : null);

Some hosts may have empty string in the charset and then IllegalArgumentException happens
in Charset.forName(..).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message