hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Leigh (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1351) Fragments Are Lost When Following Redirects
Date Sun, 19 May 2013 18:03:16 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Leigh updated HTTPCLIENT-1351:
------------------------------------

    Attachment: interpreted-location.patch

After some deliberation, the previous patch wasn't enough to resolve this issue for us. In
particular, fragment identifiers on intermediate redirects were still lost. The attached patch
resolves this issue and includes a few test cases to catch them. Also included in this patch
in a change to InternalHttpClient that resets the redirect locations and fragment identifier.
This allows the same context to be used with multiple requests without the caller actively
resetting the context. I included a test case for that as well called "testRedirectLocationsReset".
This patch builds on the previous changes/patches and ensures the http location context is
absolute and includes the interpreted fragment identifier.
                
> Fragments Are Lost When Following Redirects
> -------------------------------------------
>
>                 Key: HTTPCLIENT-1351
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1351
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.2.5
>            Reporter: James Leigh
>            Priority: Minor
>             Fix For: 4.3 Beta2
>
>         Attachments: HTTP_LOCATION.patch, interpreted-location.patch
>
>
> The current HTTP draft says that when following a redirect with a fragment identifier,
it should be processed. However, when HttpClient is set to following redirect there is no
way to recover the last fragment identifier.
>     Location = URI-reference
> http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-22#section-7.1.2
> I suggest adding a localContext attribute that contains the last fragment identifiers
as is done with the last host and last request. The relevant code is in org.apache.http.impl.client.DefaultRedirectStrategy.
> Relevant document includes:
> http://hc.apache.org/httpcomponents-client-ga/tutorial/html/httpagent.html#d5e1225
> This issue maybe related to https://issues.apache.org/jira/browse/HTTPCLIENT-1286

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message