Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Thu, 4 Apr 2013 09:53:16 +0000 (UTC)
From: "Oleg Kalnichevski (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.12631175.1360196020547.105903.1365069196159@arcas>
In-Reply-To: <JIRA.12631175.1360196020547@arcas>
References: <JIRA.12631175.1360196020547@arcas>
Subject: [jira] [Commented] (HTTPCLIENT-1319)
 InetAddressUtils.isIPv6HexCompressedAddress does not detect excess (or
 insufficient) groups
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621977#comment-13621977 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1319:
-----------------------------------------------

Sounds worthwhile to me. I would be really great if you could take care of it.

Oleg
                
> InetAddressUtils.isIPv6HexCompressedAddress does not detect excess (or insufficient) groups
> -------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1319
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1319
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.3 Alpha1
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 4.3 Final
>
>
> The IPV6 compressed format regex allows 0 or more hex groups before or after the ::.
> This does not detect too many groups (there should be at most 7 surrounding groups in total).
> It also allows no groups, i.e "::" which is not permitted AFAIK.
> The first issue could be detected by counting the number of ':' characters in the string. 
> There should be no more than 7 colons.
> The empty group could be detected by checking the length of the string - it must be at least 3 characters.
> That should probably be tested first as it is relatively cheap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org