hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Barnett (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1335) Remove final modifler from all AbstractHttpClient.execute methods
Date Wed, 03 Apr 2013 23:35:16 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Richard Barnett updated HTTPCLIENT-1335:
----------------------------------------

    Priority: Minor  (was: Major)
    
> Remove final modifler from all AbstractHttpClient.execute methods
> -----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1335
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1335
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.2.3
>            Reporter: Richard Barnett
>            Priority: Minor
>
> Of 8 AbstractHttpClient.execute methods, 4 are declared final & 4 (those with a ResponseHandler
parameter) are not.
> Remove this modifier as it prevents JMock from mocking these methods.
> It also doesn't seem to make sense for half the methods to be final.
> (Mocking the HttpClient interface is not appropriate for my tests as I have to call AbstractHttpClient.getCredentialsProvider).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message