hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1299) FileNotFoundException on Cached Variant
Date Sat, 13 Apr 2013 14:46:15 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631063#comment-13631063
] 

Oleg Kalnichevski commented on HTTPCLIENT-1299:
-----------------------------------------------

James
Could you please submit those changes as a patch (in udiff format)?

Oleg
                
> FileNotFoundException on Cached Variant
> ---------------------------------------
>
>                 Key: HTTPCLIENT-1299
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1299
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.2.3, 4.2.4, 4.3 Beta1
>         Environment: OpenJDK 64-Bit Server VM (6b24-1.11.5-0ubuntu1~12.04.1)
>            Reporter: James Leigh
>              Labels: regression
>
> This bug was introduced in org.apache.http.impl.client.cache.BasicHttpCache in 4.2.3.
> cacheAndReturnResponse takes the response and passes it to storeInCache. It then calls
generateResponse with the *same* response resource. The problem is that storeInCache passes
the resource to doGetUpdatedParentEntry, which makes a copy and *deletes* the resource it
was passed (oldResource).
> This did not occur in 4.2.2 because in 4.2.2 doGetUpdatedParentEntry did not delete the
resource. If the resource is being deleted after it is copied in 4.2.3, then it must not be
used to generateResponse.
> Here is a stack trace with line numbers.
> 	BasicHttpCache.doGetUpdatedParentEntry(String, HttpCacheEntry, HttpCacheEntry, String,
String) line: 202	
> 	BasicHttpCache$1.update(HttpCacheEntry) line: 119	
> 	ManagedHttpCacheStorage.updateEntry(String, HttpCacheUpdateCallback) line: 134	
> 	BasicHttpCache.storeVariantEntry(HttpHost, HttpRequest, HttpCacheEntry) line: 128	
> 	BasicHttpCache.storeInCache(HttpHost, HttpRequest, HttpCacheEntry) line: 96	
> 	BasicHttpCache.cacheAndReturnResponse(HttpHost, HttpRequest, HttpResponse, Date, Date)
line: 265	
> 	CachingHttpClient.handleBackendResponse(HttpHost, HttpRequest, Date, Date, HttpResponse)
line: 919	
> 	CachingHttpClient.callBackend(HttpHost, HttpRequest, HttpContext) line: 731	
> 	CachingHttpClient.handleCacheMiss(HttpHost, HttpRequest, HttpContext) line: 510	
> 	CachingHttpClient.execute(HttpHost, HttpRequest, HttpContext) line: 436	

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message