hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1238) Contribute Bundle Activator And Central Proxy Configuration
Date Wed, 17 Apr 2013 13:19:16 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634014#comment-13634014

Simone Tripodi commented on HTTPCLIENT-1238:

Thanks a lot [~olegk] for reviewing my patch! :)

let's discuss points one by one:

bq. (1) My understanding is that HttpClient OSGi bundle is dependent on HttpCore OSGi bundle
and it is responsibility of HttpCore bundle to export core packages. Can this confusion be
due to the fact that HttpClient OSGi does not correctly declare its dependency on HttpCore

Sorry, my bad - I didn't notice there is an HttpCore OSGi bundle, that makes my patch invalid
- the right way should be importing in the OSGi runtime environment the HttpCore OSGi bundle
first, then the HttpClient OSGi one.
I am honestly not a fan of declaring bundles dependencies in OSGi metadata, it is IMHO a nice
workaround for particular situations - I'll make a test with the HttpCore bundle in my runtime
and let you know

bq. (2) HttpClients interface sounds like a misnomer to me. This looks more like HttpClientBuilderFactory.
The name is uglier but more precise 

Agreed, I didn't find a better name for that interface indeed and your feedback is much more
than appreciated!

bq. (3) Can we put something in the name of the new classes to stress out their purpose and
make them more distinguishable? DefaultHttpRoutePlanner -> OSGiHttpRoutePlanner, DefaultCredentialsProvider
-> OSGiCredentialsProvider?

Yes sure, I think so, even if, since they are already under {{osgi}} package, I was looking
for a less redundant name, but having that taxonomy works for me

bq. Shall I commit the patch as is or do you want to submit another patch?

I think it is reasonable I submit a new patch, applying your feedbacks :)


PS: I'd prefer be mentioned with the _simone.tripodi_ id, _simao_ is a mistake I was not able
to delete :(
> Contribute Bundle Activator And Central Proxy Configuration
> -----------------------------------------------------------
>                 Key: HTTPCLIENT-1238
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1238
>             Project: HttpComponents HttpClient
>          Issue Type: Wish
>          Components: HttpClient
>    Affects Versions: 4.2.1
>            Reporter: Dominique Jäggi
>            Priority: Minor
>             Fix For: 4.3 Final
>         Attachments: HTTPCLIENT-1238-2.patch, HTTPCLIENT-1238-3.patch, HTTPCLIENT-1238-4.patch,
HTTPCLIENT-1238-5.patch, HTTPCLIENT-1238.patch
> as discussed at [0] i'd like to contribute the bundle activator and central proxy configuration.
> the attached patch may need some cleanup on your side, as only assumed locations where
to put some classes or in which pom.xml to put dependencies.
> i kindly ask you to review the patch in if possible integrate it in a future release.
> Adobe (and i as its employee) is available for assistance, explanations, or further dev
work required in the context of the patch.
> [0] http://mail-archives.apache.org/mod_mbox/hc-dev/201209.mbox/%3cCACMijv-21S4+Jw_A=jDFHeVB9cMt4KNi5p3jAHZFh3kvu4btdw@mail.gmail.com%3e

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message