hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Following up HTTPCLIENT-1238
Date Wed, 17 Apr 2013 09:39:40 GMT
On Wed, 2013-04-17 at 08:29 +0200, Simone Tripodi wrote:
> Hi Oleg!
> 
> as requested, I submitted a patch that is not intrusive to original
> codebase at all, it just provides an OSGi-aware component to create new
> HttpClientBuilder instances.
> 
> Can you please have a look if that could work for you, when having some
> spare time?
> 
> Many thanks in advance, all the best!
> -Simo
> 

Hi Simone

I was a little busy. Sorry about that. Reviewing your patch right at
this very instance.

Oleg


> 
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
> 
> 
> On Mon, Apr 8, 2013 at 3:28 PM, Oleg Kalnichevski <olegk@apache.org> wrote:
> 
> > On Mon, 2013-04-08 at 15:17 +0200, Simone Tripodi wrote:
> > > Hi Oleg!
> > >
> > > thanks a lot for your kind help, very appreciated! I hope to get back to
> > > the issue with a proposal very soon :)
> > >
> > > All the best,
> > > -Simo
> > >
> >
> > I am looking forward to it. Please do try to split the change set into a
> > series of smaller, incremental patches with less intrusive changes
> > first. One problem with the Dominique's patch was that it tried to
> > change too many things in too many places at the same time. While some
> > changes were good, some needed more work.
> >
> > Cheers
> >
> > Oleg
> >
> >
> > >
> > > http://people.apache.org/~simonetripodi/
> > > http://simonetripodi.livejournal.com/
> > > http://twitter.com/simonetripodi
> > > http://www.99soft.org/
> > >
> > >
> > > On Mon, Apr 8, 2013 at 1:07 PM, Oleg Kalnichevski <olegk@apache.org>
> > wrote:
> > >
> > > > On Mon, 2013-04-08 at 09:22 +0200, Simone Tripodi wrote:
> > > > > Hi all mates,
> > > > >
> > > > > I am trying to support my colleague Dominique, the original
> > > > HTTPCLIENT-1238
> > > > > reporter, on providing the patch to provide such OSGi feature.
> > > > >
> > > > > What we would like to achieve is registering proxy configuration(s)
> > that
> > > > > will be automatically picked-up by HttpClient instances, so users
> > don't
> > > > > have to manually register the proxy for each instance.
> > > > >
> > > > > In the issue I read that Oleg was working on APIs design in order
to
> > > > > achieve, more or less, the same goal, but after one day of
> > investigation
> > > > I
> > > > > haven't figured out how to do it - may I can kindly ask you if there
> > is
> > > > any
> > > > > way to implement that feature with current APIs, without adding
> > > > additional
> > > > > code?
> > > > >
> > > > > Many thanks in advance, all the best!
> > > > > -Simo
> > > > >
> > > >
> > > > Hi Simone
> > > >
> > > > Please have a look at the HttpClientBuilder and HttpClients classes in
> > > > the 4.3 branch (trunk). What I think might be a feasible approach is to
> > > > provide OSGi aware versions of those classes (similar to the caching
> > > > module). OSGi aware builder can selectively inject OSGi specific
> > > > dependencies instead of default ones or use a different
> > > > CloseableHttpCllient implementation altogether.
> > > >
> > > > Hope this helps
> > > >
> > > > Oleg
> > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > > For additional commands, e-mail: dev-help@hc.apache.org
> > > >
> > > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message