hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1329) SSLSocketFactory keystorePassword constructor parameter should be char[] instead of java.lang.String
Date Tue, 19 Mar 2013 21:25:18 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606846#comment-13606846
] 

Sebb commented on HTTPCLIENT-1329:
----------------------------------

My point was that char arrays can be cleared, whereas Strings are immutable.

If the called method clears the password, it can potentially be done a bit sooner.
But so long as it is done right after calling the method that should be OK.
                
> SSLSocketFactory keystorePassword constructor parameter should be char[] instead of java.lang.String
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1329
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1329
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.2.2
>            Reporter: David Graff
>              Labels: ssl
>
> The constructor signatures for creating an SSLSocketFactory take a java.lang.String as
a parameter.  This can lead to potential attack vectors because the password will be stored
within the string pool of the VM. As a suggestion, in a future version, deprecate this API
and add a signature taking a char[] parameter. This way the value of the password will not
be cached for an excessive duration and will be garbage collected when out of reference.
> This is based on recommendations from the GIAC Secure Software Programmer for Java course.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message