hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1444386
Date Sun, 10 Feb 2013 20:20:30 GMT
On 10 February 2013 10:20, Oleg Kalnichevski <olegk@apache.org> wrote:
> ...
>> The Javadoc should mention that the param is ignored unless > 0.
>> > +     * @see SocketOptions#SO_SNDBUF
>> > +     */
>> > +    @Deprecated
>>
>> Huh? Why add a deprecated method?
>> If it is really deprecated from birth, should include @deprecated
>> Javadoc tag with details of replacement.
>>
>
> This class started out as a classic mutable java bean with setters and
> getters. In 4.3 setters got deprecated in favor of a builder, which
> should allow us to make the class fully immutable in the future. I added
> those setters for consistency sake.

OK, I see

> Added @deprecated javadoc tags in trunk.
>
> http://svn.apache.org/viewvc?view=revision&revision=r1444523

Thanks, that looks good.

> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message