Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20F0DEF73 for ; Wed, 16 Jan 2013 03:29:41 +0000 (UTC) Received: (qmail 71493 invoked by uid 500); 16 Jan 2013 03:29:40 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 71306 invoked by uid 500); 16 Jan 2013 03:29:39 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 71201 invoked by uid 99); 16 Jan 2013 03:29:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jan 2013 03:29:38 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_DBL_REDIR X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of garydgregory@gmail.com designates 209.85.214.44 as permitted sender) Received: from [209.85.214.44] (HELO mail-bk0-f44.google.com) (209.85.214.44) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jan 2013 03:29:33 +0000 Received: by mail-bk0-f44.google.com with SMTP id w11so447962bku.31 for ; Tue, 15 Jan 2013 19:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=aan2ukl4K7cVH1QB1pr9T53kv4AvSBAXFQj6JdzQfAM=; b=LFagUAyTqs1xErAVGJAjsWgGIFzh6x2OHiwmzCVKkJUHuUIBKdzsZQBgeN5inpv7IN nSZE2oAxxLKCD1kzzovcFD8E8nDtSS5AMItdsu+I4GYDOjxOVYIoJHtnDsALWZVToXoz wx6wHEzKbg6MiYFlIxQM6ioQlOnqabgujEX8wQt+qRlvPyoQ0yOc2FWMqkFR1icBk1N3 eXDarOSlXcG5nhP1li+m1eVCRrQi3Yiz/UuxoxDo+0RzqGA1O0WlITTn5/0ZVAgYPFOw NBxmboEYeCNRALYg2XiNY7LYRiKC5pQQvoyKRgwfU7l6h080+0OTM6d4kN+s62h4QZjZ o77w== MIME-Version: 1.0 Received: by 10.204.130.140 with SMTP id t12mr41964573bks.39.1358306952315; Tue, 15 Jan 2013 19:29:12 -0800 (PST) Received: by 10.204.128.86 with HTTP; Tue, 15 Jan 2013 19:29:12 -0800 (PST) In-Reply-To: <1358261205.7634.44.camel@ubuntu> References: <1358261205.7634.44.camel@ubuntu> Date: Tue, 15 Jan 2013 22:29:12 -0500 Message-ID: Subject: Re: Use of final keyword From: Gary Gregory To: HttpComponents Project Content-Type: multipart/alternative; boundary=0015173ff1106381b404d35f7b9d X-Virus-Checked: Checked by ClamAV on apache.org --0015173ff1106381b404d35f7b9d Content-Type: text/plain; charset=UTF-8 On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski wrote: > On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: > > Over in Log4J-land, we've discussed [1] the use of the final keyword for > > locals and parameters. > > > > In brief [1]: The final keyword in trunk: sometimes it is used, sometimes > > not. I propose we use it all over consistently. > > > > [1] > http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html > > > > I tend to use final modifier for method parameters a lot (an old habit > that goes back to my Delphi programming days ;)). If it is done for > local variables (as long as it is done consistently and enforced with > the style check plugin) I would be in favor it. I would not bother with > one time exercise, though. > I added final for locals in trunk r 1433815. Gary > > Oleg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > For additional commands, e-mail: dev-help@hc.apache.org > > -- E-Mail: garydgregory@gmail.com | ggregory@apache.org JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 Spring Batch in Action: http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --0015173ff1106381b404d35f7b9d--