Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 94F5FD6EB for ; Thu, 10 Jan 2013 14:00:04 +0000 (UTC) Received: (qmail 56009 invoked by uid 500); 10 Jan 2013 14:00:04 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 55885 invoked by uid 500); 10 Jan 2013 14:00:04 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 55877 invoked by uid 99); 10 Jan 2013 14:00:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jan 2013 14:00:04 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [217.150.250.48] (HELO kalnich.nine.ch) (217.150.250.48) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jan 2013 13:59:56 +0000 Received: from [192.168.1.121] (77-57-197-206.dclient.hispeed.ch [77.57.197.206]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by kalnich.nine.ch (Postfix) with ESMTPSA id 41CE1B80187 for ; Thu, 10 Jan 2013 14:59:34 +0100 (CET) Message-ID: <1357826373.2090.23.camel@ubuntu> Subject: Re: [VOTE] HttpComponents Client 4.2.3 release based on RC2 From: Oleg Kalnichevski To: HttpComponents Project Date: Thu, 10 Jan 2013 14:59:33 +0100 In-Reply-To: References: <1357679949.12187.3.camel@ubuntu> <1357822583.2090.7.camel@ubuntu> <1357824820.2090.14.camel@ubuntu> <1357825737.2090.19.camel@ubuntu> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On Thu, 2013-01-10 at 08:52 -0500, Karl Wright wrote: > But web crawlers often cache the dns step and use an IP address > instead for the host name. In that case the host header is critical. > I imagine there are other similar situations that can arise. > One can always use an explicit HttpHost parameter, which can be a resolved IP address, to execute a request against a specific host. The request URI, though, is a purely virtual concept and this is what will define the value of the Host header. An additional virtual host parameter should have never existed. Besides, one can also plug in a custom DNS resolver that could use a custom cache of resolved DNS names. Oleg > Karl > > On Thu, Jan 10, 2013 at 8:48 AM, Oleg Kalnichevski wrote: > > On Thu, 2013-01-10 at 08:38 -0500, Karl Wright wrote: > >> Thanks. > >> > >> I don't mind if the virtual host feature goes away, as long as there > >> is some documentation about the right way to do the same thing. What > >> it seems to boil down to is whether or not HttpClient attempts to set > >> the Host header, and what it puts in there. > >> > >> Karl > >> > > > > The thing is, as long as a virtual host is resolvable via DNS, there is > > simply no need for any kind of special processing. The host name in the > > request URI request will end up in the Host header. > > > > Oleg > > > >> On Thu, Jan 10, 2013 at 8:33 AM, Oleg Kalnichevski wrote: > >> > On Thu, 2013-01-10 at 08:13 -0500, Karl Wright wrote: > >> >> The reason it was critical to ManifoldCF was only because we use the > >> >> default host with virtual host feature fairly extensively. Working > >> >> around it is possible but would require a lot of work, and we're > >> >> trying to release right now too. > >> >> > >> >> But if you feel it is not worth fixing, then please let me know. > >> >> > >> >> Karl > >> >> > >> > > >> > I'll cut RC3, no problem. Please note, though, that the virtual host > >> > parameter will no longer be supported in 4.3. The damn thing should have > >> > never existed in the first place. > >> > > >> > Oleg > >> > > >> >> On Thu, Jan 10, 2013 at 7:56 AM, Oleg Kalnichevski wrote: > >> >> > On Thu, 2013-01-10 at 11:42 +0000, sebb wrote: > >> >> >> On 10 January 2013 02:51, Karl Wright wrote: > >> >> >> > Confirmed that it IS a regression, but that the regression has been > >> >> >> > around since 4.1.2. > >> >> >> > >> >> >> Thanks for checking. > >> >> >> > >> >> >> In that case, I think it can be fixed later. > >> >> >> > >> >> > > >> >> > I do not even think this bug is major, let alone critical. It is really > >> >> > a fringe case. > >> >> > > >> >> > Oleg > >> >> > > >> >> > > >> >> >> > Karl > >> >> >> > > >> >> >> > > >> >> >> > On Wed, Jan 9, 2013 at 9:49 PM, Karl Wright wrote: > >> >> >> >> I checked in a fix and a test on trunk. Somebody please let me know > >> >> >> >> if the fix/test will be indeed going into 4.2.3. > >> >> >> >> > >> >> >> >> Thanks! > >> >> >> >> Karl > >> >> >> >> > >> >> >> >> On Wed, Jan 9, 2013 at 9:41 PM, Karl Wright wrote: > >> >> >> >>> It's apparently the result of a fix for HTTPCLIENT-1092. I am not > >> >> >> >>> sure when exactly that went in though. > >> >> >> >>> > >> >> >> >>> Karl > >> >> >> >>> > >> >> >> >>> On Wed, Jan 9, 2013 at 9:19 PM, sebb wrote: > >> >> >> >>>> On 10 January 2013 01:51, Karl Wright wrote: > >> >> >> >>>>> -1 from me (not binding), due to HTTPCLIENT-1296. :-( > >> >> >> >>>> > >> >> >> >>>> Is that a regression? > >> >> >> >>>> > >> >> >> >>>>> Karl > >> >> >> >>>>> > >> >> >> >>>>> On Tue, Jan 8, 2013 at 4:19 PM, Oleg Kalnichevski wrote: > >> >> >> >>>>>> Please vote on releasing these packages as HttpComponents Client 4.2.3. > >> >> >> >>>>>> The vote is open for the at least 72 hours, and only votes from > >> >> >> >>>>>> HttpComponents PMC members are binding. The vote passes if at least > >> >> >> >>>>>> three binding +1 votes are cast and there are more +1 than -1 votes. > >> >> >> >>>>>> > >> >> >> >>>>>> Packages: > >> >> >> >>>>>> http://people.apache.org/~olegk/httpclient-4.2.3-RC2/ > >> >> >> >>>>>> > >> >> >> >>>>>> Release notes: > >> >> >> >>>>>> http://people.apache.org/~olegk/httpclient-4.2.3-RC2/RELEASE_NOTES.txt > >> >> >> >>>>>> > >> >> >> >>>>>> Maven artefacts: > >> >> >> >>>>>> https://repository.apache.org/content/repositories/orgapachehttpcomponents-114/org/apache/httpcomponents/ > >> >> >> >>>>>> > >> >> >> >>>>>> SVN tag: > >> >> >> >>>>>> http://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.2.3-RC2/ > >> >> >> >>>>>> > >> >> >> >>>>>> -------------------------------------------------------------------------- > >> >> >> >>>>>> Vote: HttpComponents Client 4.2.3 release > >> >> >> >>>>>> [ ] +1 Release the packages as HttpComponents Client 4.2.3. > >> >> >> >>>>>> [ ] -1 I am against releasing the packages (must include a reason). > >> >> >> >>>>>> > >> >> >> >>>>>> > >> >> >> >>>>>> > >> >> >> >>>>>> --------------------------------------------------------------------- > >> >> >> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> >> >> >>>>>> For additional commands, e-mail: dev-help@hc.apache.org > >> >> >> >>>>>> > >> >> >> >>>>> > >> >> >> >>>>> --------------------------------------------------------------------- > >> >> >> >>>>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> >> >> >>>>> For additional commands, e-mail: dev-help@hc.apache.org > >> >> >> >>>>> > >> >> >> >>>> > >> >> >> >>>> --------------------------------------------------------------------- > >> >> >> >>>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> >> >> >>>> For additional commands, e-mail: dev-help@hc.apache.org > >> >> >> >>>> > >> >> >> > > >> >> >> > --------------------------------------------------------------------- > >> >> >> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> >> >> > For additional commands, e-mail: dev-help@hc.apache.org > >> >> >> > > >> >> >> > >> >> >> --------------------------------------------------------------------- > >> >> >> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> >> >> For additional commands, e-mail: dev-help@hc.apache.org > >> >> >> > >> >> > > >> >> > > >> >> > > >> >> > --------------------------------------------------------------------- > >> >> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> >> > For additional commands, e-mail: dev-help@hc.apache.org > >> >> > > >> >> > >> >> --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> >> For additional commands, e-mail: dev-help@hc.apache.org > >> >> > >> > > >> > > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> > For additional commands, e-mail: dev-help@hc.apache.org > >> > > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > >> For additional commands, e-mail: dev-help@hc.apache.org > >> > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > > For additional commands, e-mail: dev-help@hc.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org > For additional commands, e-mail: dev-help@hc.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org