hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josef Cacek (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1305) GGSSchemeBase uses CHUNKED Base64 for Authorization header
Date Fri, 25 Jan 2013 12:07:12 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562620#comment-13562620
] 

Josef Cacek commented on HTTPCLIENT-1305:
-----------------------------------------

OK, I see. We have in our project Maven dependency on commons-codec version 1.4, which uses
another constructor:

224	    public Base64() {
225	        this(false);
226	    }

http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4/src/java/org/apache/commons/codec/binary/Base64.java?view=markup

The API compatibility is not very good there.

I'll try to update our project dependency. Nevertheless, it's still more safe if the GGSSchemeBase
uses the Base64(int) constructor - then other users will not fall into this.
                
> GGSSchemeBase uses CHUNKED Base64 for Authorization header
> ----------------------------------------------------------
>
>                 Key: HTTPCLIENT-1305
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1305
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.2.3
>            Reporter: Josef Cacek
>            Priority: Critical
>
> The {{GGSSchemeBase}} member variable {{base64codec}} should not use chunked instance
of the Base64.
> Instead of
> {code}
> this.base64codec = new Base64();
> {code}
> there should be
> {code}
> //constructor with lineLength int argument. If lineLength <= 0, then the output will
not be divided into lines (chunks)
> this.base64codec = new Base64(0);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message