hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francois-Xavier Bonnet (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1290) 304 cached response never reused with If-modified-since conditional requests
Date Mon, 07 Jan 2013 18:50:14 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546142#comment-13546142

Francois-Xavier Bonnet commented on HTTPCLIENT-1290:

Oleg, I would prefer to have this bug fixed in 4.2.3 if possible.

I can make a patch but to handle this properly I need to add a field in HttpCacheEntry class
for the If-Modified-Since request header but I guess this breaks the binary compatibility
Another (less clean) solution would be to store the If-Modified-Since request header value
as a Last-Modified header in the HttpCacheEntry just for response suitability. Of course we
will remove this header from the final response.

I can make the fix tomorrow, would it be OK for you ?
> 304 cached response never reused with If-modified-since conditional requests
> ----------------------------------------------------------------------------
>                 Key: HTTPCLIENT-1290
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1290
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.2.3
>            Reporter: Francois-Xavier Bonnet
>         Attachments: HTTPCLIENT-1290.txt
> Steps to reproduce the problem:
> - cache is empty
> - send a conditional If-modified-since request
> - backend server responds with a 304 Not modified (the response does not contain the
"Last-modified" header, this conforms to rfc 2616 chapter 10.3.5)
> - the response is stored in the cache
> - send another conditional If-modified-since request
> - as the cache entry does not contain a Last-modified header to match with the If-modified-since
request header, the cache considers the entry cannot be used and sends a request again to
the backend server

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message