hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noah Levitt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-325) support custom implementations of SessionInputBuffer and SessionOutputBuffer
Date Fri, 11 Jan 2013 21:04:14 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551517#comment-13551517
] 

Noah Levitt commented on HTTPCORE-325:
--------------------------------------

The patch I submitted was just the minimal change needed to make it work. I agree that kind
of coupling with SessionInputBufferImpl is not desirable. I kinda figured you might conclude
that some refactoring was in order after looking at my patch. Specifically, making BHttpConnectionBase
use Session*Buffer instead of Session*BufferImpl. I could come up with a patch for that. I
guess it would mean pushing the *Impl methods that BHttpConnectionBase uses into the Session*Buffer
interfaces. I didn't do that initially because I thought you might have other ideas of better
ways to refactor based on your more in depth knowledge of the codebase.

How do you feel about the general idea of making Session*Buffer pluggable? I think it makes
sense. Most every other module in the library is extensible/pluggable. I'm sure there must
be other use cases for it besides mine.
                
> support custom implementations of SessionInputBuffer and SessionOutputBuffer
> ----------------------------------------------------------------------------
>
>                 Key: HTTPCORE-325
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-325
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>    Affects Versions: 4.3-alpha2
>            Reporter: Noah Levitt
>         Attachments: httpcore-325-20121231182846.diff
>
>
> In heritrix we have a set of classes that wrap streams and record them verbatim for replay.
One of the things it needs to do is make a note of where the http headers end and the message
body begins. In order to make this work with httpcomponents I found I needed custom implementations
of Session*Buffer. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message