hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noah Levitt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-325) support custom implementations of SessionInputBuffer and SessionOutputBuffer
Date Tue, 08 Jan 2013 23:10:12 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547382#comment-13547382
] 

Noah Levitt commented on HTTPCORE-325:
--------------------------------------

Hello Oleg,

(1) Heritrix is designed for web archiving, so to the extent possible, it records artifacts
verbatim. It has always supported saving http headers exactly as returned by the server. I
would be very reluctant to change that. If you take a step back and put aside knowledge of
httpcomponents, all things being equal it is clearly preferable to record everything verbatim,
and one would think there should be no technical obstacle to doing so.
(2) It would be unfortunate to have to resort to that. It means putting http parsing logic
into a place in the code that doesn't know anything about it. The http library already knows
how to recognize the end of the headers, so why write redundant code. It may even have special
logic to handle nonconformant responses, and so forth. For instance it's not just "\r\n\r\n"
it has to look for, it could be "\n\n", etc.

Noah
                
> support custom implementations of SessionInputBuffer and SessionOutputBuffer
> ----------------------------------------------------------------------------
>
>                 Key: HTTPCORE-325
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-325
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>    Affects Versions: 4.3-alpha2
>            Reporter: Noah Levitt
>         Attachments: httpcore-325-20121231182846.diff
>
>
> In heritrix we have a set of classes that wrap streams and record them verbatim for replay.
One of the things it needs to do is make a note of where the http headers end and the message
body begins. In order to make this work with httpcomponents I found I needed custom implementations
of Session*Buffer. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message