hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1433338 - /httpcomponents/project/trunk/pom.xml
Date Tue, 15 Jan 2013 11:57:44 GMT
On 15 January 2013 10:19,  <olegk@apache.org> wrote:
> Author: olegk
> Date: Tue Jan 15 10:19:55 2013
> New Revision: 1433338
>
> URL: http://svn.apache.org/viewvc?rev=1433338&view=rev
> Log:
> Added William Speirs and Karl Wright to the list of committers; externalized repostory,
snapshotRepository and site URLs to POM properties that could be overridden through custom
profiles
>
> Modified:
>     httpcomponents/project/trunk/pom.xml
>
> Modified: httpcomponents/project/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=1433338&r1=1433337&r2=1433338&view=diff
> ==============================================================================
> --- httpcomponents/project/trunk/pom.xml (original)
> +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 10:19:55 2013
> @@ -192,6 +192,24 @@ Felix bundle plugin updated: 2.3.5 -> 2.
>          <role>Committer</role>
>        </roles>
>      </developer>
> +    <developer>
> +      <name>William Speirs</name>
> +      <id>wspeirs</id>
> +      <email>wspeirs at apache.org</email>
> +      <roles>
> +        <role>Committer</role>
> +      </roles>
> +      <timezone>-5</timezone>
> +    </developer>
> +    <developer>
> +      <name>Karl Wright</name>
> +      <id>kwright</id>
> +      <email>kwright -at- apache.org</email>
> +      <roles>
> +        <role>Committer</role>
> +      </roles>
> +      <timezone>-5</timezone>
> +    </developer>
>    </developers>
>
>    <contributors>
> @@ -278,17 +296,17 @@ Felix bundle plugin updated: 2.3.5 -> 2.
>      <repository>
>        <id>apache.releases.https</id>
>        <name>Apache Release Distribution Repository</name>
> -      <url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
> +      <url>${asf.repository.url}</url>

This one does not have a property in Apache Parent Pom; not sure it
makes sense to allow it to be overridden.

>      </repository>
>      <snapshotRepository>
>        <id>apache.snapshots.https</id>
>        <name>Apache Development Snapshot Repository</name>
> -      <url>https://repository.apache.org/content/repositories/snapshots</url>
> +      <url>${asf.snapshotRepository.url}</url>

Why not use the Apache pom variable, i.e.

<distMgmtSnapshotsUrl>https://repository.apache.org/content/repositories/snapshots</distMgmtSnapshotsUrl>

The overrides could be dropped completely if delegated to the Apache Pom.

>      </snapshotRepository>
>      <site>
>        <id>apache.website</id>
>        <name>Apache Website</name>
> -      <url>scp://people.apache.org/www/hc.apache.org/</url>
> +      <url>${asf.site.url}</url>
>      </site>
>    </distributionManagement>
>
> @@ -671,6 +689,10 @@ Felix bundle plugin updated: 2.3.5 -> 2.
>     <maven.compile.deprecation>true</maven.compile.deprecation>
>     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> +   <asf.repository.url>https://repository.apache.org/service/local/staging/deploy/maven2</asf.repository.url>
> +   <asf.snapshotRepository.url>https://repository.apache.org/content/repositories/snapshots</asf.snapshotRepository.url>
> +   <asf.site.url>scp://people.apache.org/www/hc.apache.org/</asf.site.url>
> +
>     <!-- Define the Clover version here - it's needed in pluginManagement here and
the reporting sections in modules -->
>     <!-- N.B. It appears that the latest version for which the ASF has a licence is
2.6.3 -->
>     <!-- TODO - try 3.1.0 -->
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message