hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCLIENT-1285) InternalHttpClient.doExecute() clobbers context request config
Date Mon, 31 Dec 2012 17:10:13 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCLIENT-1285.
-------------------------------------------

    Resolution: Fixed

Please review

http://svn.apache.org/viewvc?rev=1427178&view=rev

Oleg
                
> InternalHttpClient.doExecute() clobbers context request config
> --------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1285
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1285
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: Snapshot
>            Reporter: Noah Levitt
>             Fix For: 4.3 Alpha1
>
>
> In InternalHttpClient.doExecute() even if HttpClientContext requestConfig has been set,
it gets replaced. Not sure what the intent is here as far as which config should take precedence,
but if "request" doesn't provide a RequestConfig, I would certainly expect the HttpClientContext
requestConfig to carry through.
>             HttpClientContext localcontext = setupContext(context);
>             HttpRoute route = determineRoute(target, wrapper, localcontext);
>             RequestConfig config = null;
>             if (request instanceof Configurable) {
>                 config = ((Configurable) request).getConfig();
>             }
>             if (config == null) {
>                 config = this.defaultConfig;
>             }
>             if (config == null) {
>                 config = HttpClientParamConfig.getRequestConfig(params);
>             }
>             localcontext.setRequestConfig(config);
> This is in trunk as of r1414680

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message