hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noah Levitt (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HTTPCLIENT-1285) InternalHttpClient.doExecute() clobbers context request config
Date Sat, 29 Dec 2012 09:38:12 GMT
Noah Levitt created HTTPCLIENT-1285:
---------------------------------------

             Summary: InternalHttpClient.doExecute() clobbers context request config
                 Key: HTTPCLIENT-1285
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1285
             Project: HttpComponents HttpClient
          Issue Type: Bug
    Affects Versions: Snapshot
            Reporter: Noah Levitt


In InternalHttpClient.doExecute() even if HttpClientContext requestConfig has been set, it
gets replaced. Not sure what the intent is here as far as which config should take precedence,
but if "request" doesn't provide a RequestConfig, I would certainly expect the HttpClientContext
requestConfig to carry through.

{code}
            HttpClientContext localcontext = setupContext(context);
            HttpRoute route = determineRoute(target, wrapper, localcontext);
            RequestConfig config = null;
            if (request instanceof Configurable) {
                config = ((Configurable) request).getConfig();
            }
            if (config == null) {
                config = this.defaultConfig;
            }
            if (config == null) {
                config = HttpClientParamConfig.getRequestConfig(params);
            }
            localcontext.setRequestConfig(config);
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message