hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1270) Improved toString() for BasicClientCookie and BasicClientCookie2
Date Fri, 07 Dec 2012 15:19:20 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526443#comment-13526443
] 

Gary Gregory commented on HTTPCLIENT-1270:
------------------------------------------

I am not a fan of the conditional exclusion of fields based on some condition (null in this
case). The toString() method is for debugging, so give me the information, if something is
null, it's just as useful information as if it is a value. Otherwise, I have to look at the
code to know why some fields are excluded.
                
> Improved toString() for BasicClientCookie and BasicClientCookie2
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1270
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1270
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpCookie
>    Affects Versions: 4.3 Alpha1
>            Reporter: Francois-Xavier Bonnet
>            Priority: Minor
>         Attachments: BasicClientCookie_patch.txt
>
>
> Improved toString() method to debug more easily. All the non-null fields of the cookie
should be visible for both classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message