Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6443AE612 for ; Mon, 26 Nov 2012 21:52:59 +0000 (UTC) Received: (qmail 48660 invoked by uid 500); 26 Nov 2012 21:52:59 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 48624 invoked by uid 500); 26 Nov 2012 21:52:59 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 48573 invoked by uid 99); 26 Nov 2012 21:52:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Nov 2012 21:52:59 +0000 Date: Mon, 26 Nov 2012 21:52:59 +0000 (UTC) From: "Gary Gregory (JIRA)" To: dev@hc.apache.org Message-ID: <2087052040.24862.1353966779123.JavaMail.jiratomcat@arcas> In-Reply-To: <1169525339.20473.1353765778153.JavaMail.jiratomcat@arcas> Subject: [jira] [Closed] (HTTPCORE-323) Undocumented UnsupportedCharsetException in org.apache.http.entity.ContentType.getOrDefault MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCORE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed HTTPCORE-323. --------------------------------- Resolution: Fixed Fix Version/s: 4.3 commit -m "Add missing Javadoc related to [HTTPCORE-323]: Undocumented UnsupportedCharsetException org.apache.http.entity.ContentType.getOrDefault." C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore-nio/src/main/java/org/apache/http/nio/entity/NStringEntity.java C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore/src/main/java/org/apache/http/entity/StringEntity.java C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore/src/main/java/org/apache/http/entity/ContentType.java C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore/src/main/java/org/apache/http/util/EntityUtils.java Sending C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore/src/main/java/org/apache/http/entity/ContentType.java Sending C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore/src/main/java/org/apache/http/entity/StringEntity.java Sending C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore/src/main/java/org/apache/http/util/EntityUtils.java Sending C:/svn/org/apache/httpcomponents/trunk/httpcore/httpcore-nio/src/main/java/org/apache/http/nio/entity/NStringEntity.java Transmitting file data ... Committed revision 1413870. commit -m "[HTTPCORE-323] Undocumented UnsupportedCharsetException in org.apache.http.entity.ContentType.getOrDefault" C:/svn/org/apache/httpcomponents/trunk/httpcore/RELEASE_NOTES.txt Sending C:/svn/org/apache/httpcomponents/trunk/httpcore/RELEASE_NOTES.txt Transmitting file data ... Committed revision 1413874. > Undocumented UnsupportedCharsetException in org.apache.http.entity.ContentType.getOrDefault > ------------------------------------------------------------------------------------------- > > Key: HTTPCORE-323 > URL: https://issues.apache.org/jira/browse/HTTPCORE-323 > Project: HttpComponents HttpCore > Issue Type: Bug > Components: HttpCore > Affects Versions: 4.2.2 > Environment: Ubuntu Linux 12.10, > Sun Java 1.7.0 > Linux kernel 3.5.0-19-generic i686 > Reporter: Viktor > Labels: bug,, charset,, httpcore,, nio, > Fix For: 4.3 > > > I have an wrong instance of HttpEntity, with illegal field "charset" (Content-Type: text/html; charset=cp-1251) in Content-Type header, and if ContentType.getOrDefault(entity) called with that entity - method throwing an uncaught exception: > java.nio.charset.UnsupportedCharsetException: cp-1251 > at java.nio.charset.Charset.forName(Charset.java:543) > at org.apache.http.entity.ContentType.create(ContentType.java:180) > at org.apache.http.entity.ContentType.create(ContentType.java:190) > at org.apache.http.entity.ContentType.get(ContentType.java:233) > at org.apache.http.entity.ContentType.getOrDefault(ContentType.java:249) > at org.apache.http.util.EntityUtils.toString(EntityUtils.java:212) > at org.apache.http.util.EntityUtils.toString(EntityUtils.java:264) > at com.rinamika.riwl.crawler.impl.LoaderImpl.processPage(LoaderImpl.java:131) > ... > I suppose that it's not right behavior because method getOrDefault must be return a defaul value if something happened. > Sorry for my English. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org