hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: Log misleading for User-Agent
Date Tue, 20 Nov 2012 02:44:21 GMT
Hi Oleg and All:

I've added in core:

   org.apache.http.util.VersionInfo.setUserAgent(HttpParams, String,
String, Class<?>)

but it is not quite right yet: The code needs adjusting to account for the
deprecated types in 4.3 {@link HttpParams} and {@link HttpProtocolParams}.

How can this be adjusted? I take the adjustment needs to wait for Oleg's
refectoring with the new config code?

Thank you,
Gary

On Sun, Nov 18, 2012 at 3:05 PM, Gary Gregory <garydgregory@gmail.com>wrote:

> On Nov 18, 2012, at 14:31, Oleg Kalnichevski <olegk@apache.org> wrote:
>
> > On Sun, 2012-11-18 at 10:35 -0500, Gary Gregory wrote:
> >
> > ...
> >
> >>>
> >>> I was just thinking that the client was the right place given the
> >>> snippet in question clearly had HttpClient specific bits.
> >>>
> >>> Anyway, feel free to put that code in a place you deem most
> appropriate.
> >>> There is now o.a.h.config package in core for configuration components.
> >>> o.a.h.utils might be another place.
> >>>
> >>
> >> Hi Oleg,
> >>
> >> I'm not sure how this would work in the o.a.h.config context. I can add
> new
> >> Utils class in o.a.h.utils but how would that be better or different
> than
> >> the deprecated HttpProtocolParams?
> >>
> >> Thank you for your guidance,
> >> Gary
> >>
> >
> > Hi Gary
> >
> > Unless I am missing something really fundamental here, adding this code
> > to a deprecated class would also make it deprecated. Unless you intend
> > to un-deprecate HttpProtocolParams would not a new class make more
> > sense?
>
> Yes and a I'll add a new class then.
>
> Gary
> >
> > Oleg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message