hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1238) Contribute Bundle Activator And Central Proxy Configuration
Date Tue, 20 Nov 2012 13:26:58 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501182#comment-13501182
] 

Oleg Kalnichevski commented on HTTPCLIENT-1238:
-----------------------------------------------

Dominique 
Sorry about the delay. I am currently in the process of making significant changes in trunk
(4.3) that directly impact the area you are working on. I was hoping to be able to commit
my changes soon but right now it looks like it is going to take a few more weeks to complete.
Please bear with me.

One thing I can tell you right way though. Inclusion of any processing logic to HttpRoute
class is a no go and a clear show stopper for me.  HttpRoute should remain a plain java bean.
Route computation logic should go into one of the HttpRoutePlanner implementations.

I am also not very hot about maintaining a global structure to keep track of all connection
manager instances. I understand it is clearly a good thing in the OSGi environment but am
a little worried it may lead to GC problems in other managed environments or containers. We
had such issues in the past. So, ideally I would prefer to have all connection manager tracking
code moved to the OSGi module while HttpClient main module would provide an abstract callback
mechanism without any implementation by default.

Once again, I think things will get easier if you submit your changes in smaller chunks.

Oleg

PS: for all the pain of having to put up with my grumblings I'll happily compensate by buying
you a drink or two next time you happen to be in Zurich.
                
> Contribute Bundle Activator And Central Proxy Configuration
> -----------------------------------------------------------
>
>                 Key: HTTPCLIENT-1238
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1238
>             Project: HttpComponents HttpClient
>          Issue Type: Wish
>          Components: HttpClient
>    Affects Versions: 4.2.1
>            Reporter: Dominique Jäggi
>            Priority: Minor
>             Fix For: 4.3 Final
>
>         Attachments: HTTPCLIENT-1238-2.patch, HTTPCLIENT-1238-3.patch, HTTPCLIENT-1238.patch
>
>
> as discussed at [0] i'd like to contribute the bundle activator and central proxy configuration.
> the attached patch may need some cleanup on your side, as only assumed locations where
to put some classes or in which pom.xml to put dependencies.
> i kindly ask you to review the patch in if possible integrate it in a future release.
> Adobe (and i as its employee) is available for assistance, explanations, or further dev
work required in the context of the patch.
> [0] http://mail-archives.apache.org/mod_mbox/hc-dev/201209.mbox/%3cCACMijv-21S4+Jw_A=jDFHeVB9cMt4KNi5p3jAHZFh3kvu4btdw@mail.gmail.com%3e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message