hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Moore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1245) org.apache.http.impl.client.cache.memcached.SHA256KeyHashingScheme use of MessageDigest should be synchronized
Date Thu, 04 Oct 2012 21:13:49 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469711#comment-13469711
] 

Jon Moore commented on HTTPCLIENT-1245:
---------------------------------------

Just to be clear, I'm open to the fact that it might be necessary, I just want to understand
why. :)

                
> org.apache.http.impl.client.cache.memcached.SHA256KeyHashingScheme use of MessageDigest
should be synchronized
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1245
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1245
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.2.1
>            Reporter: Clinton Nielsen
>
> Function:
>     public String hash(String key) {
>         MessageDigest md = getDigest();
>         md.update(key.getBytes());
>         return Hex.encodeHexString(md.digest());
>     }
> Should be rewritten to synchronize access to the MessageDigest object:
> 	public String hash(String key) {
>         MessageDigest md = getDigest();
>         byte[] digest = null;
>         synchronized(md) {
>         	md.update(key.getBytes());
>         	digest = md.digest();
>         }
>         return Hex.encodeHexString(digest);
>     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message