hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1238) Contribute Bundle Activator And Central Proxy Configuration
Date Fri, 28 Sep 2012 15:51:07 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465689#comment-13465689
] 

Oleg Kalnichevski commented on HTTPCLIENT-1238:
-----------------------------------------------

Dominique

I took a cursory look at the patch and can give you some feedback right away.

(1) There is no way we could add OSGi dependencies directly to the base module. That would
break pretty much every instance of HttpClient used outside an OSGi container. Whatever changes
we do to make HttpClient more OSGi friendly they need to be confined to the httpclient-osgi
module. 

I do not know if this is easy or possible at all but this is a few option that I can see.
One possibility would be overriding the stock versions of DefaultHttpRoutePlanner and DefaultHttpClient
through some sort of class loader magic. Alternatively we could provide an OSGi aware HttpClientBuilder
implementation (only available in 4.3 version on trunk) in the httpclient-osgi module. The
downside of the latter would be having to instruct the users to explicitly use that custom
builder when targeting OSGi environments.

(2) Is dependency on Sling Commons really necessary? Could we do without it? I could imagine
moving ProxySelector to the base module if it did not come with additional external dependencies.

(3) All this stuff should probably go into 4.3 in order to go through proper ALPHA / BETA
/ GA QA cycle. So, ideally, it should not be using any deprecated code.

Oleg
                
> Contribute Bundle Activator And Central Proxy Configuration
> -----------------------------------------------------------
>
>                 Key: HTTPCLIENT-1238
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1238
>             Project: HttpComponents HttpClient
>          Issue Type: Wish
>          Components: HttpClient
>    Affects Versions: 4.2.1
>            Reporter: Dominique Jäggi
>            Priority: Minor
>         Attachments: HTTPCLIENT-1238.patch
>
>
> as discussed at [0] i'd like to contribute the bundle activator and central proxy configuration.
> the attached patch may need some cleanup on your side, as only assumed locations where
to put some classes or in which pom.xml to put dependencies.
> i kindly ask you to review the patch in if possible integrate it in a future release.
> Adobe (and i as its employee) is available for assistance, explanations, or further dev
work required in the context of the patch.
> [0] http://mail-archives.apache.org/mod_mbox/hc-dev/201209.mbox/%3cCACMijv-21S4+Jw_A=jDFHeVB9cMt4KNi5p3jAHZFh3kvu4btdw@mail.gmail.com%3e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message