hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Castagnino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-313) ContentType.create(final String mimeType, final String charset) uncaught exception when charset == ""
Date Thu, 20 Sep 2012 07:03:07 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459400#comment-13459400
] 

Guillaume Castagnino commented on HTTPCORE-313:
-----------------------------------------------

Indeed, same as empty string. But spaces in charset are non-significant. So I would suggest
to trim the string. For example something like this:

--- ContentType.java.orig       2012-09-20 08:55:57.679827312 +0200
+++ ContentType.java    2012-09-20 08:59:51.103819363 +0200
@@ -174,7 +174,7 @@
      */
     public static ContentType create(
             final String mimeType, final String charset) throws UnsupportedCharsetException
{
-        return create(mimeType, charset != null ? Charset.forName(charset) : null);
+        return create(mimeType, charset != null && !charset.trim().isEmpty() ? Charset.forName(charset.trim())
: null);
     }
 
     private static ContentType create(final HeaderElement helem) {

                
> ContentType.create(final String mimeType, final String charset) uncaught exception when
charset == ""
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-313
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-313
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore
>    Affects Versions: 4.2.1
>         Environment: Ubuntu 12.04 LTS with openjdk-7
>            Reporter: Guillaume Castagnino
>
> I parse a broken HTTP response from a server that replies with a crafted Content-Type
header:
> Content-Type: text/html; charset=
> charset is present, but is empty. When using the EntityUtils.toString method, this triggers
an uncaught exception in ContentType.create.
> Indeed, it calls this:
> return create(mimeType, charset != null ? Charset.forName(charset) : null);
> charset is checked against the null value. But the empty string is not checked.
> Charset.forName("") throws a "java.nio.charset.IllegalCharsetNameException" exception
which is not caught whereas Charset.forName("broken") throws a "java.nio.charset.UnsupportedCharsetException"
exception, which is correctly handled.
> So I think that the empty string should be checked and managed like the null, isn't it
?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message