hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-307) Make HttpAsyncService.getRequestHandler() protected
Date Wed, 08 Aug 2012 12:45:20 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431089#comment-13431089
] 

Gary D. Gregory commented on HTTPCORE-307:
------------------------------------------

The only downside to applying this patch is that it makes binary compatibility a little harder.

Can anyone comment on whether this is appropriate as far as as 'breaking' encapsulation? After
all, it must be private for a reason.


                
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
>                 Key: HTTPCORE-307
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-307
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.2.1
>            Reporter: William R. Speirs
>             Fix For: 4.3-alpha1
>
>         Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing
something like Virtual Host support very difficult because the only way resolve a Handler
is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend
HttpAsyncService and resolve a handler based upon the whole HttpRequest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message