hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Moore (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCLIENT-1202) ResponseCachingPolicy should honor explicit cache-control directives for non-recognized status codes
Date Thu, 07 Jun 2012 19:45:23 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jon Moore resolved HTTPCLIENT-1202.

    Resolution: Fixed

@Joshua: Ok, fixed that one. We were previously requiring all cache entries to have bodies,
although this obviously doesn't make sense for caching a 204. I even added a test to verify
we could cache a 204. Please try again.
> ResponseCachingPolicy should honor explicit cache-control directives for non-recognized
status codes
> ----------------------------------------------------------------------------------------------------
>                 Key: HTTPCLIENT-1202
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1202
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.3, 4.2 Final
>            Reporter: Joshua Spiewak
>            Assignee: Jon Moore
>            Priority: Minor
>             Fix For: 4.2.1
> From my reading of [rfc2616 section 13.4|http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.4],
I see a list of response codes that MAY be stored. These correspond to the codes that ResponseCachingPolicy
checks. However, the last paragraph of the section states that other status codes MUST NOT
be returned *unless* there are cache-control directives. In my case, I am setting Cache-Control:
max-age=xxxx and as such I would expect the response to be cached.
> The return statement of ResponseCachingPolicy.isResponseCacheable looks like it was meant
to take into account explicit cache control directives, but I think that return is only ever
reached when cacheable is set to true, and is essentially not used.
> Would it be possible to enhance ResponseCachingPolicy to handle this? If not, would it
be possible to make the choice of response caching policy configurable/extensible/pluggable?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message