hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pablo Funes (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1195) URIBuilder-created query strings are double-escaped
Date Tue, 12 Jun 2012 13:53:43 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293628#comment-13293628
] 

Pablo Funes commented on HTTPCLIENT-1195:
-----------------------------------------

Here's a test that still fails with SVN version

@Test
	public void testUriBuilder() throws URISyntaxException {
		final String parameter1 = "parameter1";
		final String value1 = "ME&YOU";
		URIBuilder uriBuilder = new URIBuilder();
		uriBuilder.addParameter(parameter1, value1);
		URI uri = uriBuilder.build();
		URIBuilder uriBuilder2 = new URIBuilder(uri);
		final List<NameValuePair> queryParams = uriBuilder2.getQueryParams();
		Assert.assertEquals(value1,queryParams.get(0).getValue());
	}
                
> URIBuilder-created query strings are double-escaped
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1195
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1195
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.2 Final
>         Environment: java version "1.6.0_24"
> OpenJDK Runtime Environment (IcedTea6 1.11.1) (6b24-1.11.1-4ubuntu3)
> OpenJDK 64-Bit Server VM (build 20.0-b12, mixed mode)
>            Reporter: Chris K. Jester-Young
>             Fix For: 4.2.1
>
>
> When setting parameters in URIBuilder, the keys and values are double-escaped: once in
URIBuilder.build(), and again in URI.appendSchemeSpecificPart(). Example:
>     URIBuilder ub = new URIBuilder("http://www.google.com/");
>     ub.addParameter("foo=bar", "baz&qux");
>     ub.build();   // http://www.google.com/?foo%253Dbar=baz%2526qux
> In order to avoid this problem, URIBuilder.build() should use URI's one-argument constructor,
which does not try to do extra escaping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message