hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: URIBuilder setQuery() method inconsistent with other set methods
Date Tue, 26 Jun 2012 12:43:38 GMT
On Tue, 2012-06-26 at 12:13 +0100, sebb wrote:
> The setQuery(String) method currently expects an escaped, ASCII-only
> string - basically encoded form data - whereas all the other set
> methods expect unescaped input.
> This is a bit confusing.
> 

Yes, I am aware of it. I was going to deprecate this method in 4.3 and
replace it with something like #parseQuery.

> AFAIK, a query string does not have to consist of name value pairs
> (i.e. form data), it can be any arbitrary string.
> There's currently no way for the end-user to provide such a query.
> They would have to use the URI class.

In this case it is basically a lone parameter without a value.

> Maybe that is OK, in which case we just need to clarify the URIBuilder
> Javadoc to state that it is only intended for use with form data
> queries.
> 
> Perhaps there should be a setQuery(NVP) method which handles form data directly?
> 

Makes sense. The question is whether we should add this method in 4.2.1
or wait until 4.3. 

Oleg

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message