hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCORE-298) SSLIOSession state can get out of sync with underlying IOSession state
Date Sun, 06 May 2012 13:09:50 GMT

     [ https://issues.apache.org/jira/browse/HTTPCORE-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCORE-298.
----------------------------------------

    Resolution: Fixed

I reviewed the code and found some fairly rare but legitimate situations when the I/O reactor
had to close an I/O session. So, the proposed fix makes good sense. Committed to SVN trunk.

Oleg  
                
> SSLIOSession state can get out of sync with underlying IOSession state
> ----------------------------------------------------------------------
>
>                 Key: HTTPCORE-298
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-298
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 4.1.4
>         Environment: observed on Ubuntu 10.0.4, but I think it could happen anywhere
>            Reporter: Sandeep Tamhankar
>             Fix For: 4.2.1
>
>
> Under heavy load, I've observed my application call SSLIOSession.isClosed() to decide
if the connection can be reused for a pending outbound request. It returns false. However,
the underlying IOSessionImpl is actually closed. I believe that AbstractIOReactor also holds
a reference to that underlying IOSession and it can be independently closed from that end.
> My proposed fix is simple (and very non-invasive, but possibly not correct in that I
don't have the SSLIOSession update its state upon discovering that the underlying IOSession
is closed): update SSLIOSession.isClosed as followed:
>     public boolean isClosed() {
>         return this.status >= CLOSING || this.session.isClosed();
>     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message