Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 209.85.214.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1335343473.27980.4.camel@ubuntu>
References: 
 <CAOGo0VbmECT08D7rc5goq_tshwm6dsyFNaFzYMq5Q9QO57D8Gw@mail.gmail.com>
	<1335343473.27980.4.camel@ubuntu>
Date: Wed, 25 Apr 2012 09:49:14 +0100
Message-ID: 
 <CAOGo0VayU6HzWFOw_Vhz=G3ypZWS++WwqddvcecOAJWghwQf_w@mail.gmail.com>
Subject: Re: r1327298 StringEntity and NStringEntity static method deletions -
 intentional?
From: sebb <sebbaz@gmail.com>
To: HttpComponents Project <dev@hc.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On 25 April 2012 09:44, Oleg Kalnichevski <olegk@apache.org> wrote:
> On Wed, 2012-04-25 at 01:39 +0100, sebb wrote:
>> The log for r1327298 says:
>>
>> URL: http://svn.apache.org/viewvc?rev=1327298&view=rev
>> Log:
>> HTTPCORE-297: ContentType to use Charset instead of String to
>> represent the charset parameter
>>
>> However, the commit also removed some static methods from StringEntity
>> [1] and NStringEntity [2] - was that intentional?
>>
>
> Yes, it was intentional. Those static #create method were primarily
> needed to re-throw checked UnspportedEncodingException as unchecked
> IllegalArgumentException. Since charset validation moved to the
> ContentType class there was no longer any good reason for having static
> #create method in StringEntity and NStringEntity.

OK, in that case one of the HttpClient test cases needs fixing:

client.TestBasicResponseHandler.testSuccessfulResponse() calls
StringEntity.create()


> Oleg
>
>> [1] http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/entity/StringEntity.java?rev=1327298&r1=1327297&r2=1327298&view=diff
>>
>>
>> [2] http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NStringEntity.java?view=diff&r1=1327297&r2=1327298&pathrev=1327298
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> For additional commands, e-mail: dev-help@hc.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org