hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralf Pöhlmann (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1186) NTLM authenticated connections are mixed
Date Tue, 24 Apr 2012 14:03:36 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260570#comment-13260570
] 

Ralf Pöhlmann commented on HTTPCLIENT-1186:
-------------------------------------------

It's hard to provide a test case, as this test case would require a NTLM-enabled server.

Unfortunately I fail to see where the state of the connection gets updated. The method ManagedClientConnection.setState()
seems to be called by DefaultRequestDirector.execute() only. Looking at that method I fail
to see where the connection gets updated other than within the code snippet I posted above.
As this code does not check if the current connection already has a userToken, userTokens
will not be set on new connections.

Could you please point me towards the code which updates the connection and is supposed to
set the user token.

                
> NTLM authenticated connections are mixed
> ----------------------------------------
>
>                 Key: HTTPCLIENT-1186
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1186
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.1.3
>            Reporter: Ralf Pöhlmann
>            Priority: Critical
>              Labels: DefaultRequestDirector
>
> Executing multiple request using the same http context as recommended mixes authenticated
connections among different users. 
> If we execute two request usign the same context, the first request adds the user token
to the http context as well as to the connection properties. The second request fins already
a user token in the http context but if a new connection will be created (no free connection
in the pool) this new connection is never assigned to an user token and is used independent
of any user context!
> see DefaultRequestDirector:
> // See if we have a user token bound to the execution context
> Object userToken = context.getAttribute(ClientContext.USER_TOKEN);
> ...
> if (managedConn != null && userToken == null) {
>    userToken = userTokenHandler.getUserToken(context);
>    context.setAttribute(ClientContext.USER_TOKEN, userToken);
>    if (userToken != null) {
>       managedConn.setState(userToken);
>    }
> }
> and RouteSpecificPool:
>     public BasicPoolEntry allocEntry(final Object state) {
>         if (!freeEntries.isEmpty()) {
>             ListIterator<BasicPoolEntry> it = freeEntries.listIterator(freeEntries.size());
>             while (it.hasPrevious()) {
>                 BasicPoolEntry entry = it.previous();
>                 if (entry.getState() == null || LangUtils.equals(state, entry.getState()))
{
>                     it.remove();
>                     return entry;
>                 }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message