hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: r1327298 StringEntity and NStringEntity static method deletions - intentional?
Date Wed, 25 Apr 2012 08:44:33 GMT
On Wed, 2012-04-25 at 01:39 +0100, sebb wrote:
> The log for r1327298 says:
> 
> URL: http://svn.apache.org/viewvc?rev=1327298&view=rev
> Log:
> HTTPCORE-297: ContentType to use Charset instead of String to
> represent the charset parameter
> 
> However, the commit also removed some static methods from StringEntity
> [1] and NStringEntity [2] - was that intentional?
> 

Yes, it was intentional. Those static #create method were primarily
needed to re-throw checked UnspportedEncodingException as unchecked
IllegalArgumentException. Since charset validation moved to the
ContentType class there was no longer any good reason for having static
#create method in StringEntity and NStringEntity.

Oleg

> [1] http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/entity/StringEntity.java?rev=1327298&r1=1327297&r2=1327298&view=diff
> 
> 
> [2] http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NStringEntity.java?view=diff&r1=1327297&r2=1327298&pathrev=1327298
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message