Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Thu, 12 Jan 2012 13:51:39 +0000 (UTC)
From: "Jon Moore (Commented) (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: 
 <70203296.34502.1326376299766.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <666637700.11708.1325800359443.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HTTPCLIENT-1157) MemcachedHttpCacheStorage
 should throw IOExceptions instead of Runtime Exceptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184965#comment-13184965 ] 

Jon Moore commented on HTTPCLIENT-1157:
---------------------------------------

@Oleg: I see you beat me to it. Thanks. :)

                
> MemcachedHttpCacheStorage should throw IOExceptions instead of Runtime Exceptions
> ---------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1157
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1157
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.2 Alpha1
>            Reporter: James Miller
>            Assignee: Jon Moore
>              Labels: cache
>             Fix For: 4.1.3, 4.2 Alpha2
>
>         Attachments: HTTPCLIENT-1157.patch, httpclient-1157-2.patch
>
>
> The MemcachedHttpCacheStorage class implements HttpCacheStorage which defines that methods will throw IOExceptions, but the underlying net.spy.memcached.MemcachedClientIF throws runtime exceptions. These exceptions are not caught in the code where IOExceptions are expected causing these exception bubble up to the calling code. It seems like the MemcachedHttpCacheStorage class should treat at least some of these runtime exceptions as IOExceptions so that normal code execution paths can be followed.  
> I'm proposing that MemcachedHttpCacheStorage treat a OperationTimeoutException from the memcached client as an IOException. This would allow the existing CachingHttpClient code to catch and log the exception as a warning, instead of bubbling the exception up the calling code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org